Skip to content

Feat/UI improvement #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Animesh404 wants to merge 12 commits into from
Closed

Feat/UI improvement #921

Animesh404 wants to merge 12 commits into from

Conversation

@Animesh404
Copy link
Member

@Animesh404 Animesh404 commented Nov 16, 2024

A WIP PR for #892

Summary

added video column in dashboard with some UI improvements overall
image

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

 python -m openadapt.app.dashboard.run

@abrichr
Copy link
Member

abrichr commented Nov 18, 2024

Thank you @Animesh404 ! Can you please upload a short video demonstrating the screenshot animation/playback functionality we discussed?

@Animesh404
Copy link
Member Author

Animesh404 commented Nov 19, 2024

Thank you @Animesh404 ! Can you please upload a short video demonstrating the screenshot animation/playback functionality we discussed?

Untitled.video.-.Made.with.Clipchamp.1.mp4

abrichr
abrichr reviewed Jan 18, 2025
View reviewed changes
abrichr
abrichr reviewed Jan 18, 2025
View reviewed changes
openadapt/app/dashboard/components/FramePlayer/FramePlayer.tsx Outdated
@@ -0,0 +1,120 @@
"use client"
Copy link
Member

@abrichr abrichr Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep things consistent with the rest of the code, how about we stick with four spaces? We can refactor everything to two spaces later.

Copy link
Member Author

@Animesh404 Animesh404 Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in b6f5c40

abrichr
abrichr reviewed Jan 20, 2025
View reviewed changes
openadapt/app/dashboard/app/routes.ts Outdated
IconSettings,
IconEraser,
IconBook
} from '@tabler/icons-react';
Copy link
Member

@abrichr abrichr Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the formatting here and elsewhere. Your IDE should be able to do this for you.

Copy link
Member Author

@Animesh404 Animesh404 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done via prettier in bd3e923

@abrichr
Copy link
Member

abrichr commented Jan 17, 2026

Closing as part of the architecture transition. The legacy codebase has been moved to legacy/ and frozen at v0.46.0.

If this change is still needed, please:

  1. Open a PR against the relevant modular package repository
  2. Or re-open this PR targeting the legacy/ directory if it's a critical legacy fix

See PR #960 for details on the new meta-package architecture.

@abrichr abrichr closed this Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrichr abrichr abrichr left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Animesh404 @abrichr